search

cypress-io / cypress-realworld-app

A payment application to demonstrate real-world usage of Cypress testing methods, patterns, and workflows.
https://docs.cypress.io
MIT License
5.52k stars 2.22k forks source link

Migrate away from `react-virtualized` #1555

Open markerikson opened 4 months ago

markerikson commented 4 months ago

Hi! We've got a fork at https://github.com/replayio-public/cypress-realworld-app that we've been using to generate Cypress runs for use with Replay.io.

I'm in the process of getting our fork set up to build with React 18 and 19, and saw that both MUI v4 and react-virtualized broke with React 19 due to uses of findDOMNode.

I looked over here and saw that #1418 had already done the work to migrate to MUI v5. Cherry-picked all those commits and can confirm the tests still pass.

For react-virtualized, I looked at its newer alternative react-window (both of which were actually written by my current Replay teammate Brian Vaughn), and saw that he'd written a replacement package of react-window-infinite-loader for the infinite loading setup.

I just got the <TransactionInfiniteList> component ported over to use that and tests pass, so I wanted to give you a heads-up in case you wanted to cherry-pick those changes over:

MikeMcC399 commented 2 months ago

@markerikson