search

cypress-io / cypress-realworld-testing

Next.js project for learn.cypress.io
https://learn.cypress.io
MIT License
77 stars 63 forks source link

chore(deps): update to node.js 20.9.0 LTS Iron #320

Closed MikeMcC399 closed 11 months ago

MikeMcC399 commented 1 year ago

This PR updates

from 16.16.0 to 20.9.0.

See announcement Node v20.9.0 (LTS).

Reason

Verification

Clone the repo to Ubuntu 22.04 (not WIndows!):

git clone https://github.com/cypress-io/cypress-realworld-testing.git
cd cypress-realworld-testing

Install and test

With Node.js 20.9.0 execute the following instructions:

yarn install
yarn dev # starts dev server

In a separate terminal window, execute:

export SITE_URL=https://learn.cypress.io
yarn cypress:run

Confirm that all tests pass.

vercel[bot] commented 1 year ago

@MikeMcC399 is attempting to deploy a commit to the Cypress Team on Vercel.

A member of the Team first needs to authorize it.

MikeMcC399 commented 1 year ago

This PR will not be successful until the issue with Chrome 117 crashes in headless mode is resolved. Leaving in draft status until this time.

The workaround of updating Cypress to > 12.14.0 is not a quick fix, since the tests are only compatible with Cypress 10.x and 11.x. The tests would need to be reworked to be compatible.

MikeMcC399 commented 11 months ago

Yarn install shows several warnings:

$ yarn install
yarn install v1.22.19
[1/4] Resolving packages...
[2/4] Fetching packages...
[3/4] Linking dependencies...
warning "@docsearch/react > @algolia/autocomplete-preset-algolia@1.7.1" has unmet peer dependency "@algolia/client-search@^4.9.1".
warning "@zeit/next-css > css-loader@1.0.0" has unmet peer dependency "webpack@^4.0.0".
warning "@zeit/next-css > mini-css-extract-plugin@0.4.3" has unmet peer dependency "webpack@^4.4.0".
warning " > ts-node@10.1.0" has unmet peer dependency "@types/node@*".
warning " > url-loader@4.1.1" has unmet peer dependency "webpack@^4.0.0 || ^5.0.0".
[4/4] Building fresh packages...
Done in 17.86s.

An older version of Cypress is in use here:

$ yarn list --pattern cypress
yarn list v1.22.19
├─ @cypress/request@2.88.10
├─ @cypress/xvfb@1.2.4
└─ cypress@10.5.0

The following test passes:

export SITE_URL=https://learn.cypress.io
yarn cypress:run
MikeMcC399 commented 11 months ago

Closed due to lack of response.