cypress-io / cypress

Fast, easy and reliable testing for anything that runs in a browser.
https://cypress.io
MIT License
46.72k stars 3.16k forks source link

Convert `npm/**/examples/**` tests to `system-tests` #19088

Closed flotwig closed 1 year ago

flotwig commented 2 years ago

There are 24 example projects in npm/**/examples/**:

➜  cypress git:(develop) ✗ echo npm/**/examples/** | xargs -n1 echo             
npm/react/examples/a11y
npm/react/examples/craco
npm/react/examples/find-webpack
npm/react/examples/nextjs
npm/react/examples/nextjs-webpack-5
npm/react/examples/react-scripts
npm/react/examples/react-scripts-folder
npm/react/examples/react-scripts-typescript
npm/react/examples/sass-and-ts
npm/react/examples/snapshots
npm/react/examples/tailwind
npm/react/examples/using-babel
npm/react/examples/using-babel-typescript
npm/react/examples/visual-sudoku
npm/react/examples/visual-testing-with-applitools
npm/react/examples/visual-testing-with-happo
npm/react/examples/visual-testing-with-percy
npm/react/examples/webpack-file
npm/react/examples/webpack-options
npm/vue/examples/code-coverage
npm/vue/examples/vue-cli
npm/webpack-preprocessor/examples/react-app
npm/webpack-preprocessor/examples/use-babelrc
npm/webpack-preprocessor/examples/use-ts-loader
➜  cypress git:(develop) ✗ echo npm/**/examples/** | xargs -n1 echo | wc -l
24

All of these can be converted to system-tests. This is especially important to save CI time and cost for the example projects that require yarn install, since currently we're running yarn install for each one of those projects, for each commit.

Partially blocked by #18574 which adds the yarn install caching to system-tests.

JessicaSachs commented 2 years ago

We're tracking this internally in UNIFY-1265

lmiller1990 commented 1 year ago

We did this, closing.