cypress-io / cypress

Fast, easy and reliable testing for anything that runs in a browser.
https://cypress.io
MIT License
47.02k stars 3.19k forks source link

Clicking breadcrumbs for project doesn't do anything on some pages in the Launchpad #21911

Closed sync-by-unito[bot] closed 2 years ago

sync-by-unito[bot] commented 2 years ago

Summary

my-app-ts on the left corner is clickable, but when it’s clicked it does nothing - the continue in the bottom on the page needs to be clicked to change the view otherwise it stays there..

image (1) image (2)

https://cypressio.slack.com/archives/C02MYBT9Y5S/p1652977080252969

Acceptance Criteria

┆Issue is synchronized with this Jira Task by Unito ┆Attachments: 10.0 - can go back during project setup and get in confusing state.mp4 | image (1).png | image (2).png ┆author: Alejandro Estrada ┆epic: UI/UX Improvements ┆friendlyId: UNIFY-1776 ┆priority: Medium ┆sprint: Fast Follows 1 ┆taskType: Task

sync-by-unito[bot] commented 2 years ago

➤ Jennifer Shehane commented:

I can "Go Back" during project setup and end up in a confusing state. Users probably shouldn't be able to click "projectName" after scaffolding since we want them to scroll down and "Continue".

Via Zach Bloomquist

!10.0 - can go back during project setup and get in confusing state.mp4|width=1268,height=776!

https://cypressio.slack.com/archives/C02MW5QBD4K/p1652983395819639 ( https://cypressio.slack.com/archives/C02MW5QBD4K/p1652983395819639|smart-card )

sync-by-unito[bot] commented 2 years ago

➤ Jennifer Shehane commented:

Via Muaz Othman

When setting up testing for the first time, there is a step in both E2E and Component Testing where the only option is to “Continue” at the bottom of the page, and clicking the project name in the breadcrumb at the top does nothing. https://www.loom.com/share/a3bb6dba7e854e72a7f4ffc266c698c3 ( https://www.loom.com/share/a3bb6dba7e854e72a7f4ffc266c698c3|smart-link ) https://www.loom.com/share/62589b47ab3f47eaa9a5d9cae443a9e3 ( https://www.loom.com/share/62589b47ab3f47eaa9a5d9cae443a9e3|smart-link )

https://cypressio.slack.com/archives/C02MYBT9Y5S/p1652983520005119 ( https://cypressio.slack.com/archives/C02MYBT9Y5S/p1652983520005119|smart-card )

marktnoonan commented 2 years ago

This project-name link in the Launchpad header currently only ever takes the user back to the "Testing Type" picker. The only valid place to from which to go back to that part of the launchpad is when you are at the "Choose a Browser" stage. The link should never be clickable if:

Since the "Choose a Browser" page already has a prominent link to "switch testing types", my suggestion is that for now, we just don't make the project name in the header a link.

In the original designs, the "switch testing type" link was not a part of the "Choose a Browser" screen, but now that it exist, the header link is made redundant by the more obvious button that does the same thing.

@ryanjwilke what do you think of this? My thinking is that making sure the link is only active when "safe" to go back to the testing type picker doesn't help users that much, but creates edge cases that have to be guarded against.

ryanjwilke commented 1 year ago

@marktnoonan Sorry I'm just seeing this notification now. I've been cleaning out my inbox because Apple Mail is pretty terrible. The breadcrumb links should be linked in the top left only when there is something that it can actually be linked to. There are some new designs in the works which should simplify this a little more for navigation globally. Also, moving everything back into the Launchpad should theoretically fix this particular problem as well I believe.

marktnoonan commented 1 year ago

This one's no longer an issue - it looks like you and I discussed it at the time and changed the behavior in https://github.com/cypress-io/cypress/pull/22648