cypress-io / cypress

Fast, easy and reliable testing for anything that runs in a browser.
https://cypress.io
MIT License
47.01k stars 3.18k forks source link

Remove support for non-operational CI provider "Shippable" #26253

Closed MikeMcC399 closed 1 year ago

MikeMcC399 commented 1 year ago

What would you like?

Remove redundant code in:

and other repositories owned by https://github.com/cypress-io/

which supported the CI provider "Shippable".

Why is this needed?

The provider is no longer operating and the CI domain https://app.shippable.com which was previously hosting https://app.shippable.com/github/cypress-io/cypress-example-kitchensink no longer exists.

Removing the code is a clean-up activity.

Background

The former CI provider "Shippable" no longer provides a service.

Related PRs

jennifer-shehane commented 1 year ago

@MikeMcC399 We’re open to a PR to clean this up in Cypress.

MikeMcC399 commented 1 year ago

Considering that the latest releases of the following npm modules used by Cypress 13.3.0 continue to list "Shippable" as an active CI provider, it may generate unexpected problems to remove Shippable from the Cypress code base. The potential risk does not justify the benefits of a clean-up attempt in this case, since the continued presence of the "Shippable" code in Cypress is not known to generate any issues.

Module Cypress uses
ci-info@3.9.0 3.8.0
is-ci@3.0.1 3.0.1

Additionally used in the Cypress repo by semantic-release@19.0.3:

Module Cypress uses
env-ci@10.0.0 5.0.2
@npmcli/ci-detect@3.0.2 2.0.0

(@npmcli/ci-detect is deprecated and replaced by ci-info)

Closing this issue.

Edit: ci-info@4.0.0 removed "Shippable CI".