search

cypress-io / cypress

Fast, easy and reliable testing for anything that runs in a browser.
https://cypress.io
MIT License
46.43k stars 3.14k forks source link

(Electron) Cypress pauses every single request in Unnecessarily #26621

Open AtofStryker opened 1 year ago

AtofStryker commented 1 year ago

Current behavior

Currently in Electron, Cypress pauses every single request coming from the app to determine if the frame making the request is the AUT frame. This is really only needed to happen on ResourceType document requests. We have some data to suggest that possibly not pausing on every single request might improve performance of general network timings in the form of reducing blocking time.

Desired behavior

Cypress requests should only be paused if the request being made is a document request. This scope of work includes supporting this for electron once Cypress has upgraded to Electron v25. Type filtering does not look to be supported until Electron v25 (see commit)

See parent issue for more details #26620

Test code to reproduce

N/A. enable electron browser debug logs to see every inbound request in the pause handler

Cypress Version

12.11.0

Node version

v16.16.0

Operating System

macOS 12.6

Debug Logs

No response

Other

No response

cypress-app-bot commented 8 months ago

This issue has not had any activity in 180 days. Cypress evolves quickly and the reported behavior should be tested on the latest version of Cypress to verify the behavior is still occurring. It will be closed in 14 days if no updates are provided.

cypress-app-bot commented 8 months ago

This issue has been closed due to inactivity.