cypress-io / cypress

Fast, easy and reliable testing for anything that runs in a browser.
https://cypress.io
MIT License
46.71k stars 3.16k forks source link

Update WebKit testing to 18.x #29954

Open MikeMcC399 opened 1 month ago

MikeMcC399 commented 1 month ago

What would you like?

Test Cypress with current WebKit 17.x 18.x instead of 16.0.

Why is this needed?

The current version of WebKit is 17.4 18.0.

CircleCI tests with WebKit 16.0 in

derived from playwright-webkit@1.24.2, released 2 years ago on July 29, 2022.

This is not representative of expected current usage of WebKit.

Other

The latest version of playwright is 1.45.3, released July 22, 2024 1.47.0, released Sep 5, 2024.

MikeMcC399 commented 1 month ago
MikeMcC399 commented 1 month ago

driver-integration-tests-webkit fails using playwright-webkit@1.45.3

This can be reproduced locally with

yarn
yarn workspace @packages/driver cypress:run --browser webkit --spec cypress/e2e/commands/cookies.cy.js

Testing with lower versions of playwright-webkit shows that the highest working version is playwright-webkit@1.34.3, which corresponds to the previous recommendation on the documentation site under WebKit (Experimental).

Version Result WebKit
1.24.2 pass v16
1.34.3 pass v16
1.35.1 pass (1) v16
1.36.2 pass (1) v17
1.37.1 fail v17

The cookies incompatibility to playwright-webkit 1.37.1 and later needs separate investigation.

MikeMcC399 commented 1 month ago
MikeMcC399 commented 1 month ago

Updated to WebKit 18.0 due to release on Aug 5, 2024.