cypress-io / cypress

Fast, easy and reliable testing for anything that runs in a browser.
https://cypress.io
MIT License
47.09k stars 3.19k forks source link

chore: repro failing verify-accessibility-results contributor PR job #30472

Closed MikeMcC399 closed 3 weeks ago

MikeMcC399 commented 3 weeks ago

THIS PR SHOULD NOT BE MERGED

Additional details

This is a no-op PR from a contributor fork demonstrating the failure of the CircleCI job verify-accessibility-results.

Steps to test

Allow PR to run in CircleCI.

How has the user experience changed?

This PR is a no-op (enpty commit) and does not change anything.

PR Tasks

cypress-app-bot commented 3 weeks ago
jennifer-shehane commented 3 weeks ago

@MikeMcC399 We have a PR here to fix this: https://github.com/cypress-io/cypress/pull/30476

MikeMcC399 commented 3 weeks ago

@jennifer-shehane

  • We have a PR here to fix this: #30476

Thanks! It seems you'll have to merge the PR before I can test it from this fork PR.

jennifer-shehane commented 3 weeks ago

@MikeMcC399 Seems to be working. https://app.circleci.com/pipelines/github/cypress-io/cypress/65017/workflows/7323bdfe-c0e9-4823-acf5-75a201c4a527/jobs/2703021

Screenshot 2024-10-28 at 10 52 31 AM

MikeMcC399 commented 3 weeks ago

@jennifer-shehane

Seems to be working.

Yes, it's no longer failing. It's just strangely orphaned and not part of the flow. Every other test is done after the build has finished.

image

jennifer-shehane commented 3 weeks ago

@MikeMcC399 Yah, it will never run on a contributor PR, so I think this is fine to signal early.