search

cypress-io / cypress

Fast, easy and reliable testing for anything that runs in a browser.
https://cypress.io
MIT License
47.1k stars 3.19k forks source link

deprecation: Deprecate resource type of intercept's request object #30512

Closed jennifer-shehane closed 2 weeks ago

jennifer-shehane commented 3 weeks ago

Additional details

In order to potentially remove proxy correlation, we need to remove the dependency on resourceType. In addition, since the values come from CDP, with the transition to BiDi, these values may no longer be the same.

Our intention is to replace essential functionality dependent on the resourceType within Cypress (like hiding network logs that are not fetch/xhr) in a future version.

Steps to test

How has the user experience changed?

PR Tasks

cypress[bot] commented 3 weeks ago

cypress    Run #58066

Run Properties:  status check passed Passed #58066  •  git commit b2ee2fde1e: Add changelog entry
Project cypress
Branch Review deprecate-resource-type
Run status status check passed Passed #58066
Run duration 21m 42s
Commit git commit b2ee2fde1e: Add changelog entry
Committer Jennifer Shehane
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 5
Tests that did not run due to a developer annotating a test with .skip  Pending 1327
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 29368
View all changes introduced in this branch ↗︎
UI Coverage  46.24%
  Untested elements 188  
  Tested elements 166  
Accessibility  92.55%
  Failed rules  3 critical   8 serious   2 moderate   2 minor
  Failed elements 899