search

cypress-io / cypress

Fast, easy and reliable testing for anything that runs in a browser.
https://cypress.io
MIT License
47.09k stars 3.19k forks source link

chore: remove react dependency from the server as it looks unused #30515

Closed AtofStryker closed 2 weeks ago

AtofStryker commented 3 weeks ago

Additional details

Removes a stale react dependency from the server package as it isn't used. This should make https://github.com/cypress-io/cypress/issues/30510 easier to accomplish

Steps to test

How has the user experience changed?

PR Tasks

cypress[bot] commented 2 weeks ago

cypress    Run #58107

Run Properties:  status check passed Passed #58107  •  git commit 8bdc016356: chore: remove react dependency from the server as it looks unused [run ci]
Project cypress
Branch Review chore/remove_react_server
Run status status check passed Passed #58107
Run duration 24m 01s
Commit git commit 8bdc016356: chore: remove react dependency from the server as it looks unused [run ci]
Committer AtofStryker
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 7
Tests that did not run due to a developer annotating a test with .skip  Pending 1326
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 29395
View all changes introduced in this branch ↗︎
UI Coverage  46.11%
  Untested elements 189  
  Tested elements 166  
Accessibility  92.55%
  Failed rules  3 critical   8 serious   2 moderate   2 minor
  Failed elements 903  
AtofStryker commented 2 weeks ago

@AtofStryker I think you need to run yarn.

@jennifer-shehane There are no lock file changes. Likely because the same version is already installed in the lock globally. I double checked to make sure

cypress-bot[bot] commented 2 weeks ago

Released in 13.15.2.

This comment thread has been locked. If you are still experiencing this issue after upgrading to Cypress v13.15.2, please open a new issue.