cypress-io / cypress

Fast, easy and reliable testing for anything that runs in a browser.
https://cypress.io
MIT License
47.09k stars 3.19k forks source link

chore: Update CI workflows path to be current branch workflows file #30534

Closed jennifer-shehane closed 2 weeks ago

jennifer-shehane commented 2 weeks ago

Additional details

There were some tests failing in strange ways when contributor PRs were run on our release/14 branch (see https://github.com/cypress-io/cypress/pull/29680). Some of the tests were running in the new Node version and some in the old Node version.

It turns out that for contributor PRs, they always pull in the workflow.yml from the develop branch to run. We don't see any utility in doing CI this way, so I'm updating the code to checkout the code and run the .circleci/workflows.yml file that is in the working directory.

Steps to test

Test of this was conducted in this outside contributor PR: https://github.com/cypress-io/cypress/pull/30520

How has the user experience changed?

N/A

PR Tasks

cypress[bot] commented 2 weeks ago

cypress    Run #58126

Run Properties:  status check passed Passed #58126  •  git commit f1c3744ebc: empty commit
Project cypress
Branch Review remove-workflow-file-check
Run status status check passed Passed #58126
Run duration 25m 14s
Commit git commit f1c3744ebc: empty commit
Committer Jennifer Shehane
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 6
Tests that did not run due to a developer annotating a test with .skip  Pending 1326
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 29395
View all changes introduced in this branch ↗︎
UI Coverage  46.24%
  Untested elements 188  
  Tested elements 166  
Accessibility  92.55%
  Failed rules  3 critical   8 serious   2 moderate   2 minor
  Failed elements 908