search

cypress-io / cypress

Fast, easy and reliable testing for anything that runs in a browser.
https://cypress.io
MIT License
47.1k stars 3.19k forks source link

breaking: remove support for Angular <17.2.0 for Cypress Component Testing #30539

Closed AtofStryker closed 2 weeks ago

AtofStryker commented 3 weeks ago

Additional details

Removes CT support for angular versions under 17.2.0. This is needed in order to merge the angular-signals test harness into the main test harness #29606. This also updates the cypress-schematic to have a peer dependency on angular 17.2.0 and up and updates the tests to use the latest devkit and leverages vitest in band instead of mocha/chai

Steps to test

How has the user experience changed?

PR Tasks

cypress[bot] commented 3 weeks ago

cypress    Run #58203

Run Properties:  status check passed Passed #58203  •  git commit 74f853bc1e: breaking: remove support for angular 13,14,15, and 16. minimum version is now 17...
Project cypress
Branch Review breaking/remove_angular_under_17_2
Run status status check passed Passed #58203
Run duration 17m 29s
Commit git commit 74f853bc1e: breaking: remove support for angular 13,14,15, and 16. minimum version is now 17...
Committer AtofStryker
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 4
Tests that did not run due to a developer annotating a test with .skip  Pending 1327
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 29317
View all changes introduced in this branch ↗︎
UI Coverage  46.67%
  Untested elements 187  
  Tested elements 168  
Accessibility  92.55%
  Failed rules  3 critical   8 serious   2 moderate   2 minor
  Failed elements 893  
AtofStryker commented 2 weeks ago

@cypress/schematic looks to function as intended as well as dependency checking from CLI. @cypress/schematic will need some more testing once the package is released but everything in this PR looks good (will add to checklist or prerelease/release items)