cypress-io / cypress

Fast, easy and reliable testing for anything that runs in a browser.
https://cypress.io
MIT License
47.09k stars 3.19k forks source link

breaking: remove the cypress/angular-signals test harness. The changes incorporated in @cypress/angular-signals are now merged upstream into @cypress/angular and the package is no longer needed #30540

Closed AtofStryker closed 2 weeks ago

AtofStryker commented 2 weeks ago

Additional details

merges the angular-signals test harness implemented in #29621 upstream into cypress/angular and deleted the angular-signals test harness as we no longer need it.

Screenshot 2024-11-07 at 9 06 01 AM

changing the import from cypress/angular-signals to cypress/angular works as expected and signals is natively supported in cypress/angular

Screenshot 2024-11-07 at 9 07 07 AM

Steps to test

How has the user experience changed?

PR Tasks

cypress[bot] commented 2 weeks ago

cypress    Run #58223

Run Properties:  status check passed Passed #58223  •  git commit ddd40669a2: breaking: remove the cypress/angular-signals test harness. The changes incorpora...
Project cypress
Branch Review breaking/remove_angular_signals_test_harness
Run status status check passed Passed #58223
Run duration 17m 34s
Commit git commit ddd40669a2: breaking: remove the cypress/angular-signals test harness. The changes incorpora...
Committer AtofStryker
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 27
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 765
View all changes introduced in this branch ↗︎
UI Coverage  68.29%
  Untested elements 24  
  Tested elements 56  
Accessibility  96.21%
  Failed rules  0 critical   4 serious   1 moderate   0 minor
  Failed elements 202