cypress-io / cypress

Fast, easy and reliable testing for anything that runs in a browser.
https://cypress.io
MIT License
47.09k stars 3.19k forks source link

fix: ensure that each js file served up by vite dev server has an inline sourcemap #30606

Closed ryanthemanuel closed 1 week ago

ryanthemanuel commented 1 week ago

Additional details

We have a custom vite dev server plugin that transforms JS files to include inlined source maps but there were two scenarios that were missed with this plugin:

This PR resolves both of these scenarios.

Steps to test

How has the user experience changed?

PR Tasks

cypress[bot] commented 1 week ago

cypress    Run #58405

Run Properties:  status check passed Passed #58405  •  git commit 46206bf448: Merge branch 'develop' into ryanm/fix/ensure-that-each-served-js-file-in-vite-de...
Project cypress
Branch Review ryanm/fix/ensure-that-each-served-js-file-in-vite-dev-server-has-a-sourcemap
Run status status check passed Passed #58405
Run duration 17m 41s
Commit git commit 46206bf448: Merge branch 'develop' into ryanm/fix/ensure-that-each-served-js-file-in-vite-de...
Committer Ryan Manuel
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 2
Tests that did not run due to a developer annotating a test with .skip  Pending 77
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 5588
View all changes introduced in this branch ↗︎


[!WARNING]

No Report: Something went wrong and we could not generate a report for the Application Quality products.

ryanthemanuel commented 1 week ago

does this fix the code frame issue we were seeing with vite and component testing?

Unfortunately, no that is more complicated to resolve however this will get us where we need to get to in order to properly have sourcemaps available in the protocol space.

cypress-bot[bot] commented 2 days ago

Released in 13.16.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to Cypress v13.16.0, please open a new issue.