cypress-io / github-action

GitHub Action for running Cypress end-to-end & component tests
https://on.cypress.io/guides/continuous-integration/github-actions
MIT License
1.35k stars 357 forks source link

test: remove pnpm store caching #1188

Closed MikeMcC399 closed 3 months ago

MikeMcC399 commented 3 months ago

Issue

Workflows such as .github/workflows/example-basic-pnpm.yml, which attempt to cache the contents of the pnpm store, fail sporadically, especially after there has been a change in the version of Cypress and where pnpm workflow jobs are running in parallel.

If the cache of the pnpm store cache is loaded with the cypress module, through steps outside of the Cypress GitHub action, and the Cypress binary has not been successfully cached by the action, then Cypress fails with a verification error.

There is no mechanism available to coordinate these two different caching mechanisms. (See also https://github.com/cypress-io/github-action/issues/1179#issuecomment-2125265169 for further explanation.)

Change

pnpm store caching is removed from the documentation:

README > pnpm

and replaced by text which recommends against this caching.

The following workflows are amended accordingly:

Related

cypress-app-bot commented 3 months ago
MikeMcC399 commented 3 months ago

Preview

README > pnpm

MikeMcC399 commented 3 months ago

Force pushed with no changes to test caching on subsequent runs. Test was successful.

github-actions[bot] commented 3 months ago

:tada: This PR is included in version 6.7.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: