ci(deps): update main workflow node.js to 20.13.1

cypress-io / github-action

GitHub Action for running Cypress end-to-end & component tests

MIT License

1.35k stars 357 forks source link

Closed MikeMcC399 closed 1 month ago

MikeMcC399 commented 1 month ago

The .github/workflows/main.yml workflow is intended to run with the same Node.js version as defined in https://github.com/actions/runner/blob/main/src/Misc/externals.sh in order to provide a representative CI test.

The workflow currently uses Node.js 20.8.1

whereas the GitHub runner has been updated to use NODE20_VERSION="20.13.1" in the meantime

Update Node.js in .github/workflows/main.yml from 20.8.1 to 20.13.1.

cypress-app-bot commented 1 month ago

Create a Draft Pull Request if your PR is not ready for review. Mark the PR as Ready for Review when you're ready for a Cypress team member to review the PR.

MikeMcC399 commented 1 month ago

This PR fails with Node.js 22 picking up 22.5.0. This version contains a regression https://github.com/nodejs/node/issues/53902. The regression is fixed in 22.5.1 which was released in the last hour. GitHub will catch up and it should all be good soon. Nevertheless, I will leave the PR in draft state until all tests are passing. The PR is not urgent.

npm error Exit handler never called!

is mentioned in the release notes for Node.js 22.5.1

github-actions[bot] commented 1 month ago

:tada: This PR is included in version 6.7.2 :tada:

The release is available on:

Your semantic-release bot :package::rocket: