search

cypress-io / github-action

GitHub Action for running Cypress end-to-end & component tests
https://on.cypress.io/guides/continuous-integration/github-actions
MIT License
1.35k stars 356 forks source link

Add shrinkwrap support #80

Open 8BitJonny opened 4 years ago

8BitJonny commented 4 years ago

The problem

You cannot use this Github Action plugin if your project uses a shrinkwrap.json. Even if you want to fix it by providing a custom cache key line 73 in index.js will still be executed and fail the running github action.

https://github.com/cypress-io/github-action/blob/7e682f64d9972e9da5aafd95dcb0558de8381a84/index.js#L62-L90

bahmutov commented 4 years ago

Could you submit a pull request - it would need to handle package lock, yarn and shrink wrap files

Sent from my iPhone

On Feb 1, 2020, at 11:25, Timon Christiansen notifications@github.com wrote:

 The problem

You cannot use this Github Action plugin if your project uses a shrinkwrap.json. Even if you want to fix it by providing a custom cache key line 73 in index.js will still be executed and fail the running github action.

https://github.com/cypress-io/github-action/blob/7e682f64d9972e9da5aafd95dcb0558de8381a84/index.js#L62-L90

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or unsubscribe.

8BitJonny commented 4 years ago

Yap, I'll go ahead and work on it 👍

MikeMcC399 commented 9 months ago

@8BitJonny

Yap, I'll go ahead and work on it 👍

I couldn't find any follow-up for this. Is it still relevant for you?

8BitJonny commented 9 months ago

@MikeMcC399 Oh sorry, totally lost track of this. No its not relevant for me anymore and hence its up for grabs again