search

cyprieng / swagger-parser

Give useful informations about your swagger files
MIT License
62 stars 59 forks source link

Use isinstance for simple type checking #36

Closed pankaj28843 closed 7 years ago

pankaj28843 commented 7 years ago

As per %timeit in IPython, new implementation takes half time as compared to old one. I used following code to test:

values = ['abcd', 234, False, True, None, {}, [], object(), 2.7]
_types = [_has_simple_type_1(x) for x in values]
cyprieng commented 7 years ago

Nice, I will merge this. Then I will check why the build is failing on python 2.6 as it is not related to this PR. Thanks :+1: