cyrealtype / Lora-Cyrillic

Lora fonts — serif family for text. Variable Open Source Font
http://www.cyreal.org/fonts/lora/
SIL Open Font License 1.1
413 stars 34 forks source link

Vertical metrics #9

Closed m4rc1e closed 8 years ago

m4rc1e commented 8 years ago

Hey mate,

Your vert metrics differ from the fonts being server from the google fonts api.

This is not really an error, since you are the owner. It's up to you whether you revert them.

screen shot 2016-11-14 at 13 29 32

m4rc1e commented 8 years ago

Also, this was the only questionable thing I could find ;-)

the meta data, folder structure etc was very good.

alexeiva commented 8 years ago

thank you @m4rc1e. In this case let's revert back to legacy metrics.

The reason this pops up collection-wide is that all my new metrics were based on 125% rule. However this should be decided upon on a case-to-case basis

alexeiva commented 8 years ago

Just ran @m4rc1e's inherit legacy metrics script to fix issue

Output for Roman masters:

Master: Regular Font: Regular 
PASS: local typoAscender 944 is == to remote typoAscender 944
ERROR: local winAscent 1206.22473145 is not == to remote winAscent 944
FIXING: Regular winAscent
PASS: local typoLineGap 0 is == to remote typoLineGap 0
PASS: local hheaLineGap 0 is == to remote hheaLineGap 0
PASS: local hheaAscender 944 is == to remote hheaAscender 944
PASS: local hheaDescender -269 is == to remote hheaDescender -269
PASS: local typoDescender -269 is == to remote typoDescender -269
ERROR: local winDescent -284.0 is not == to remote winDescent 269
FIXING: Regular winDescent
UPDATING: Regular winAscent to 1206.22475058
UPDATING: Regular winDescent to -284.0

Master: Bold Font: Bold 
PASS: local typoAscender 1006 is == to remote typoAscender 1006
ERROR: local winAscent 1206.22473145 is not == to remote winAscent 1006
FIXING: Bold winAscent
PASS: local typoLineGap 0 is == to remote typoLineGap 0
PASS: local hheaLineGap 0 is == to remote hheaLineGap 0
PASS: local hheaAscender 1006 is == to remote hheaAscender 1006
PASS: local hheaDescender -274 is == to remote hheaDescender -274
PASS: local typoDescender -274 is == to remote typoDescender -274
ERROR: local winDescent -284.0 is not == to remote winDescent 274
FIXING: Bold winDescent
UPDATING: Bold winAscent to 1206.22475058
UPDATING: Bold winDescent to -284.0
End

Output for Italic masters:

Start
***Check vertical metrics match hosted version on fonts.google.com***

Master: Regular Font: Italic 
ERROR: local typoAscender 1206 is not == to remote typoAscender 960
FIXING: Regular typoAscender
ERROR: local winAscent 1206 is not == to remote winAscent 960
FIXING: Regular winAscent
PASS: local typoLineGap 0 is == to remote typoLineGap 0
PASS: local hheaLineGap 0 is == to remote hheaLineGap 0
ERROR: local hheaAscender 1206 is not == to remote hheaAscender 960
FIXING: Regular hheaAscender
ERROR: local hheaDescender -284 is not == to remote hheaDescender -271
FIXING: Regular hheaDescender
ERROR: local typoDescender -284 is not == to remote typoDescender -271
FIXING: Regular typoDescender
ERROR: local winDescent 294 is not == to remote winDescent 271
FIXING: Regular winDescent
UPDATING: Regular winAscent to 1076.09769708
UPDATING: Regular winDescent to -294.0

Master: Bold Font: BoldItalic 
ERROR: local typoAscender 1206 is not == to remote typoAscender 1033
FIXING: Bold typoAscender
ERROR: local winAscent 1206 is not == to remote winAscent 1033
FIXING: Bold winAscent
PASS: local typoLineGap 0 is == to remote typoLineGap 0
PASS: local hheaLineGap 0 is == to remote hheaLineGap 0
ERROR: local hheaAscender 1206 is not == to remote hheaAscender 1033
FIXING: Bold hheaAscender
ERROR: local hheaDescender -284 is not == to remote hheaDescender -274
FIXING: Bold hheaDescender
ERROR: local typoDescender -284 is not == to remote typoDescender -274
FIXING: Bold typoDescender
ERROR: local winDescent 294 is not == to remote winDescent 274
FIXING: Bold winDescent
UPDATING: Bold winAscent to 1076.09769708
UPDATING: Bold winDescent to -294.0
End

Easy fix. Works like a charm. after:

screen shot 2016-11-21 at 11 49 53 am screen shot 2016-11-21 at 11 50 04 am screen shot 2016-11-21 at 11 50 19 am screen shot 2016-11-21 at 11 50 28 am