cyrilcc / org.openhab.binding.rflink

RFLink binding for OpenHAB 2.0
23 stars 32 forks source link

Issue with sending Tristate messages #65

Open owainlloyd opened 2 years ago

owainlloyd commented 2 years ago

Just upgraded to the OH3 and took new binding. I have some cheap sockets that use the TriState type. Old binding use to work sending messages but the new one no longer works. I was using a very old version 2.3.0.

Taking a look it looks like in the buildmessage in RfLinkBaseMessage.java there is an assumption that the channel should be a 8 character string where as for Tristate its only 6 characters.

eg the message being send is 10;TriState;0082aaa1;10;ON; when it should be 10;TriState82aaa1;10;ON I've tested this by sending the commands directly and the later on does work.

In the 2.3.0 version there isnt the use the mask. Looks like it was increased from 6 to 8 as part of issue #23 by @johnjore

I'm going to do a quick fix on a local version to change the mask back to 6 but might need some help getting a more permanent fix in the code as I'm VERY rusty!