Caching view counts cannot be empty - Githubissues

cyrildewit / eloquent-viewable

Associate views with Eloquent models in Laravel

MIT License

829 stars 105 forks source link

Caching view counts cannot be empty #250

Closed francoism90 closed 3 years ago

francoism90 commented 3 years ago

Eloquent Viewable: 6.0.0
Laravel Version: 8.12
PHP Version: 7.4.1
Database Driver & Version: MariaDB

Description:

The default value null of the $lifetime argument of the remember method has been removed.

The README still provides empty $lifetime examples and the docblock also seems to allow be incorrect. Think this is an easy fix. :)

Steps To Reproduce:

Upgrade to V6
Use remember()
Get error

Expected behavior:

Lifetime should be provided.

Actual behavior:

Lifetime should be defined error.

cyrildewit commented 3 years ago

Should be fixed now.