search

cyrildewit / eloquent-viewable

Associate views with Eloquent models in Laravel
MIT License
829 stars 105 forks source link

PHP 8.2 support #284

Closed vbezruchkin closed 1 year ago

vbezruchkin commented 1 year ago

Please add PHP 8.2 support:

PHP Deprecated:  Using ${var} in strings is deprecated, use {$var} instead in 
./vendor/cyrildewit/eloquent-viewable/src/InteractsWithViews.php on line 74

Deprecated: Using ${var} in strings is deprecated, use {$var} instead in 
./vendor/cyrildewit/eloquent-viewable/src/InteractsWithViews.php on line 74

Thanks!

cyrildewit commented 1 year ago

Hey,

This is fixed by #280 right? The master branch still needs to be made stable. Maybe you can work on that part.

See my comment https://github.com/cyrildewit/eloquent-viewable/issues/283#issuecomment-1476837501 for more context.

Thanks.

cyrildewit commented 1 year ago

I will close this in favor of #283