cyrilgdn / terraform-provider-postgresql

Terraform PostgreSQL provider
https://www.terraform.io/docs/providers/postgresql/
Mozilla Public License 2.0
359 stars 182 forks source link

postgresql_default_privileges param "owner" should be optional #246

Closed awoimbee closed 1 year ago

awoimbee commented 1 year ago

Looking at the doc: https://www.postgresql.org/docs/current/sql-alterdefaultprivileges.html

The name of an existing role of which the current role is a member. If FOR ROLE is omitted, the current role is assumed.

So owner should be optional (or am I missing something ?) (see the SQL query here).

I would also make it clearer which of owner and role is target_role and role_name.

awoimbee commented 1 year ago

Ok no it's useless to make it optional. I should've looked at stackoverflow before: https://stackoverflow.com/a/22684537/8502653