cyrilgdn / terraform-provider-postgresql

Terraform PostgreSQL provider
https://www.terraform.io/docs/providers/postgresql/
Mozilla Public License 2.0
375 stars 194 forks source link

New feature : Add Azure Active directory authentication when using Azure postgresql servers #37

Open younux opened 3 years ago

younux commented 3 years ago

Hello, Is it possible to add a new feature to the provider : Connecting to Azure database postgresql using Azure Active DIrectory authentication as described here The idea is that the password is a token that is fetched from Azure active directory using clientSecretCrentials. I have already forked the project and implement this feature, I can make a pull request if you are ok to add this feature to this provider. What do you think about it ? Thanks for your feedback

cyrilgdn commented 3 years ago

Hi @younux ,

Thanks for opening this issue (and sorry for the response delay, I missed some notifications from Github :man_facepalming: )

Yes we could be interested by this feature, it depends of the implementation. Could you open the PR so I can see how it looks?

Thanks for your work on that!

SemMulder commented 3 years ago

Hi @cyrilgdn and @younux,

I am also interested in this!

I checked the branch @younux wrote and saw he was using a different approach than the azurerm and azuread Terraform providers. To make it easy to use for people already using either of those I thought it would be nice if the postgres provider supported the exact same way of configuration, especially because there are a lot of ways to authenticate with Azure (client secrets, managed identities, via the az cli, etc.). That's why I started a new branch here: https://github.com/SemMulder/terraform-provider-postgresql/tree/add-aad-authentication. I hope to have an initial working version later this week.

Just a heads up to prevent possible duplicate work :)

younux commented 3 years ago

Hello @SemMulder

The approach I used is for addressing the problem with the simplest possible way : easy to use and easy to understand (KISS principle).

I am not against your approach if is accepted. The important for me is to support this use case.

Regards,

mathiasbecher commented 1 year ago

Hi, @younux, @SemMulder

Is anyone still working on this feature?