search

cyrilou242 / ftcc

Fast Text Classification with Compressors dictionary
MIT License
146 stars 10 forks source link

Update main.py (added csv export) #4

Closed CaltropHungerton closed 1 year ago

CaltropHungerton commented 1 year ago

added a function that exports the accuracy, speed, and size results as csv files.

cyrilou242 commented 1 year ago

Nice thanks! Adding a few comments

cyrilou242 commented 1 year ago

LGTM thanks!

Could you add a mention in the readme that the results are written to accuracy_results.csv, speed_results.csv and size_results.csv?

CaltropHungerton commented 1 year ago

LGTM thanks!

Could you add a mention in the readme that the results are written to accuracy_results.csv, speed_results.csv and size_results.csv?

I also got rid of the TODO bullet point. I think there are a couple of other bullet points that we might be able to get rid of (add ohsumed dataset, has pytorch already been removed?) but you would know better than I would.

cyrilou242 commented 1 year ago

LGTM thanks! Could you add a mention in the readme that the results are written to accuracy_results.csv, speed_results.csv and size_results.csv?

I also got rid of the TODO bullet point. I think there are a couple of other bullet points that we might be able to get rid of (add ohsumed dataset, has pytorch already been removed?) but you would know better than I would.

Thanks! I'll clean up the todo.