search

cyrilwanner / next-optimized-images

🌅 next-optimized-images automatically optimizes images used in next.js projects (jpeg, png, svg, webp and gif).
MIT License
2.21k stars 93 forks source link

fix undeterminist detected loaders #220

Open guillaumeLamanda opened 3 years ago

guillaumeLamanda commented 3 years ago

Fix the issue I ran into when upgrading my project to NextJS 10.

I Added more information in my comment on #219.

Not sure it totally close it, but the initial comment on the issue is unclear...

About the change, I think the path resolution was too restrictive and too sharp specific.
I updated the adapter condition and adapter path resolution. All checks are OK.

codecov-io commented 3 years ago

Codecov Report

Merging #220 (bfc875e) into master (fe31e5c) will not change coverage. The diff coverage is 50.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #220   +/-   ##
=======================================
  Coverage   88.42%   88.42%           
=======================================
  Files          13       13           
  Lines         190      190           
  Branches       46       46           
=======================================
  Hits          168      168           
  Misses         16       16           
  Partials        6        6
Impacted Files Coverage Δ
lib/loaders/responsive-loader.js 72.72% <50.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update fe31e5c...bfc875e. Read the comment docs.