Kernel module build failure: error: ‘struct <anonymous>’ has no member named ‘ResumeFromSuspend’

[ganto]

When I try to build CoreFreq (release 1.93.1 or current master) on a Gentoo machine against kernel 6.1.1 it fails with:

make -j1 -C /lib/modules/6.1.1-gentoo/build M=/var/tmp/portage/sys-apps/corefreq-1.93.1/work/CoreFreq-1.93.1 modules
make[1]: warning: -j1 forced in submake: resetting jobserver mode.
make[1]: Entering directory '/usr/src/linux-6.1.1-gentoo'
  CC [M]  /var/tmp/portage/sys-apps/corefreq-1.93.1/work/CoreFreq-1.93.1/corefreqk.o
/var/tmp/portage/sys-apps/corefreq-1.93.1/work/CoreFreq-1.93.1/corefreqk.c: In function ‘CoreFreqK_HotPlug_CPU_Online’:
/var/tmp/portage/sys-apps/corefreq-1.93.1/work/CoreFreq-1.93.1/corefreqk.c:21795:17: error: ‘struct <anonymous>’ has no member named ‘ResumeFromSuspend’
21795 |    if (CoreFreqK.ResumeFromSuspend == false)
      |                 ^
compilation terminated due to -Wfatal-errors.
make[2]: *** [scripts/Makefile.build:250: /var/tmp/portage/sys-apps/corefreq-1.93.1/work/CoreFreq-1.93.1/corefreqk.o] Error 1
make[1]: *** [Makefile:1992: /var/tmp/portage/sys-apps/corefreq-1.93.1/work/CoreFreq-1.93.1] Error 2

System:

• glibc-2.36-r5

  GNU C Library (Gentoo 2.36-r5 p5) stable release version 2.36.
  Copyright (C) 2022 Free Software Foundation, Inc.
  This is free software; see the source for copying conditions.
  There is NO warranty; not even for MERCHANTABILITY or FITNESS FOR A
  PARTICULAR PURPOSE.
  Compiled by GNU CC version 11.3.0.
  libc ABIs: UNIQUE IFUNC ABSOLUTE
  Minimum supported kernel: 3.2.0
  For bug reporting instructions, please see:
  <https://bugs.gentoo.org/>.

• gcc-11.3.1_p20221209

  Using built-in specs.
  COLLECT_GCC=gcc
  COLLECT_LTO_WRAPPER=/usr/libexec/gcc/x86_64-pc-linux-gnu/11/lto-wrapper
  Target: x86_64-pc-linux-gnu
  Configured with: /var/tmp/portage/sys-devel/gcc-11.3.1_p20221209/work/gcc-11-20221209/configure --host=x86_64-pc-linux-gnu --build=x86_64-pc-linux-gnu --prefix=/usr --bindir=/usr/x86_64-pc-linux-gnu/gcc-bin/11 --includedir=/usr/lib/gcc/x86_64-pc-linux-gnu/11/include --datadir=/usr/share/gcc-data/x86_64-pc-linux-gnu/11 --mandir=/usr/share/gcc-data/x86_64-pc-linux-gnu/11/man --infodir=/usr/share/gcc-data/x86_64-pc-linux-gnu/11/info --with-gxx-include-dir=/usr/lib/gcc/x86_64-pc-linux-gnu/11/include/g++-v11 --with-python-dir=/share/gcc-data/x86_64-pc-linux-gnu/11/python --enable-languages=c,c++,go,fortran --enable-obsolete --enable-secureplt --disable-werror --with-system-zlib --enable-nls --without-included-gettext --disable-libunwind-exceptions --enable-checking=release --with-bugurl=https://bugs.gentoo.org/ --with-pkgversion='Gentoo 11.3.1_p20221209 p3' --with-gcc-major-version-only --disable-esp --enable-libstdcxx-time --disable-libstdcxx-pch --enable-shared --enable-threads=posix --enable-__cxa_atexit --enable-clocale=gnu --enable-multilib --with-multilib-list=m32,m64 --disable-fixed-point --enable-targets=all --enable-libgomp --disable-libssp --disable-libada --disable-cet --disable-systemtap --disable-valgrind-annotations --disable-vtable-verify --disable-libvtv --with-zstd --enable-lto --with-isl --disable-isl-version-check --enable-default-pie --enable-default-ssp
  Thread model: posix
  Supported LTO compression algorithms: zlib zstd
  gcc version 11.3.1 20221209 (Gentoo 11.3.1_p20221209 p3)

[cyring]

Sorry for that bug. Until I fix it, please build your kernel with CONFIG_PM_SLEEP

[cyring]

To reproduce your issue, I'm removing any SUSPEND, HIBERNATE features and others dependencies found (remove XEN, but keep ACPI)

EDIT: second attempt to build a PM_SLEEP free kernel

Now rebooting that kernel ...

EDIT: Issue reproduced

corefreqk.c:22098:17: error: ‘struct <anonymous>’ has no member named ‘ResumeFromSuspend’
22098 |    if (CoreFreqK.ResumeFromSuspend == false)

[cyring]

Please pull, build and run CoreFreq from the develop branch (until the fix gets merged into master).

[ganto]

Sorry, I might not have the most standard kernel configuration. Thanks a lot for the quick fix. Works perfectly fine now.

You can find some quickly done ebuilds in my overlay at sys-apps/corefreq and sys-apps/corefreq-kmod. For the module build I needed to add a separate make target (1.93.1-Add-separate-target-to-build-kernel-module.patch). Maybe you can also add this to your Makefile?

[cyring]

Sorry, I might not have the most standard kernel configuration. Thanks a lot for the quick fix. Works perfectly fine now.

You can find some quickly done ebuilds in my overlay at sys-apps/corefreq and sys-apps/corefreq-kmod. For the module build I needed to add a separate make target (1.93.1-Add-separate-target-to-build-kernel-module.patch). Maybe you can also add this to your Makefile?

Thanks a lot for your contribution.

I'm thinking about referencing your ebuild either as an external git sub-project or to mention a link in the Readme.md within a gentoo section : the goal in any case is to let you maintain the packaging. Second choice is the easiest for me but Some don't read docs ...

I want to help with 1.93.1-Add-separate-target-to-build-kernel-module.patch and my understanding is that the module keyword makes the difference. Non regression has to be done on all distributions: ArchLinux, Opensuse, Unraid, Redhat(s), Debian(s), ClearLinux, in addition to Gentoo; from v3 to v6 kernels If Makefile fails then project becomes a brick ...

[cyring]

Please feel free to come back here if you have an issue.