search

cyring / CoreFreq

CoreFreq : CPU monitoring and tuning software designed for 64-bit processors.
https://www.cyring.fr
GNU General Public License v2.0
1.97k stars 126 forks source link

Wrong unit used for RAM maximum capacity? #403

Closed antermin closed 1 year ago

antermin commented 1 year ago

Maximum Capacity:33554432 bytes

But 33554432 bytes equals 0.03125 GB only.

It should probably be Kilobytes? 33554432 bytes equals 32 GB.

cyring commented 1 year ago

Hello,

I don't find where you are getting Maximum Capacity from ?

Can you show me a screenshot ?

antermin commented 1 year ago

I don't find where you are getting Maximum Capacity from ?

Hello, please refer to the output of corefreq-cli in #401 and #400.

It is above the IMC section.

cyring commented 1 year ago

I don't find where you are getting Maximum Capacity from ?

Hello, please refer to the output of corefreq-cli in #401 and #400.

It is above the IMC section.

I see, this is not computed by CoreFreq but sourced directly from the SMBIOS field. If value is buggy on many PC cases, I may remove it from display.

antermin commented 1 year ago

https://www.dmtf.org/sites/default/files/standards/documents/DSP0134_3.3.0.pdf

Page 92:

Maximum memory capacity, in kilobytes, for this array

So if SMBIOS returns 33554432, it means that it is 33554432 kilobytes, so is not buggy in this case.

Probably the string needs to be edited (changing the word bytes to kilobytes)?

cyring commented 1 year ago

https://www.dmtf.org/sites/default/files/standards/documents/DSP0134_3.3.0.pdf

Page 92:

Maximum memory capacity, in kilobytes, for this array

So if SMBIOS returns 33554432, it means that it is 33554432 kilobytes, so is not buggy in this case.

Probably the string needs to be edited (changing the word bytes to kilobytes)?

Good point. I will change unit to kilobytes

cyring commented 1 year ago

What do you think about this one from AMD EPYC 7V12 64-Core Processor ?

2199023255552

Would that mean platform has a max memory capacity of 2 PB ?

antermin commented 1 year ago

In the case of EPYC 7V12, it seems to make more sense if the value is in bytes instead of kilobytes.

I wonder if some vendors or platforms are returning buggy values or using wrong units?

cyring commented 1 year ago

Meanwhile I have commit the change in branch of development.

This will cover the max of cases. We let the User find by him-herself the buggy case.

cyring commented 1 year ago

Fixed