cyrus-and / chrome-har-capturer

Capture HAR files from a Chrome instance
MIT License
535 stars 90 forks source link

Add request priority and initiator to the HAR #29

Closed paulirish closed 8 years ago

paulirish commented 8 years ago

Prefixed with an underscore as they are custom, nonstandard fields

cyrus-and commented 8 years ago

Thanks, there is an _initiator field already, but it is a child of the entry. I think that initiator and priority are more related to the object itself rather than the request. What do you think?

P.S. Since you're rebasing in any case, do you mind putting the chmod +x in a separate commit?

paulirish commented 8 years ago

Hah. Sorry I had missed the initiator completely. That's excellent.

Yes I'll nuke my initiator change and separate the mode change. Cheers

paulirish commented 8 years ago

updated.

cyrus-and commented 8 years ago

Great, thank you! I moved the _priority field outside the request object though; I think it makes more sense there, for what concerns the HAR context.

paulirish commented 8 years ago

Cool. Works for me!