Added support for non --headless browser.

cyrus-and / chrome-har-capturer

Capture HAR files from a Chrome instance

MIT License

535 stars 90 forks source link

Added support for non --headless browser. #53

Closed Setitch closed 7 years ago

Setitch commented 7 years ago

Added code to work under chrome running without --headless flag, also added something (which should turn off throttling for hidden tabs - by activating them)

cyrus-and commented 7 years ago

Apart from the fact that this PR fails all the tests and uses a different code style... why would one use a non-headless browser now that the feature is fully supported in stable Chrome?

Making it work for non-headless Chrome is a real pain due to the lack of browser contexts, merely creating a new tab is not enough. I don't know if you're aware, but I purposefully removed the support for non-headless Chrome a while back (da5efa0223ab26083da978e1d2d6a65b4f432d87).

Setitch commented 7 years ago

i didnt knew you removed it
where pain - you just open new browser instead of tab (which i also fixed providing host and port to commands)
for some reason on several computers with windows - chrome headless works from 10 to 30times slower than nonheadless - for this reason i need to be able to use the library on both fronts - and thats the main reason i need nonheadless support