search

cyruseuros / ewal

GNU General Public License v3.0
30 stars 2 forks source link

Light theme highlight nearly invisible #1

Open ericjuma opened 4 years ago

ericjuma commented 4 years ago

In the spacemacs theme, highlight is set to be 4 shades lighter than the background. This is visible with dark themes but not with light themes. It makes helm unusable because it's used for the helm-selection face.

cyruseuros commented 4 years ago

Thanks for reporting this! I don't really use light themes much so the odds of me catching this were slim.

I just pushed a change to develop that addresses your problem but might also cause other ones - it inverts the shade number for light colors.

Would you mind setting ewal-dark-pallete-p to t and checking out what your theme looks like on the develop branch now?

I gave it a brief look, and it seems alright, but I'd like your input on any "jarring" changes you see since I'm overly sensitive to the palette itself.