search

cyruseuros / ewal

GNU General Public License v3.0
30 stars 2 forks source link

Require spacemacs-theme instead of spacemacs-common #5

Closed tarsius closed 1 year ago

tarsius commented 1 year ago

"spacemacs-common.el" was renamed to "spacemacs-theme.el".

Closes #4.

cyruseuros commented 1 year ago

Tested to work - I no longer have a wal+Spacemacs config to test with

tarsius commented 1 year ago

I don't quite understand. You intend to merge this, don't you?

cyruseuros commented 1 year ago

Sorry, there was a question mark missing there. I meant to ask if you tested out the patch. That said, it seems rather trivial and spacemacs theme does indeed (provide 'spacemacs-theme) now, was just curious why the PR was closed instead of merged. Guess I'll just merge this and look into handing over my packages to the Emacs orphanage or something.

tarsius commented 1 year ago

I meant to ask if you tested out the patch.

I didn't actually test, since I don't use this theme. This is just a tiny part of my continues effort to ensure that all packages provide a library whose name matches that of the package, and to fix other easily detectable defect of all the packages on the Emacsmirror (including the Melpa subset). I.e., I open a bunch of pull-requests like this every week, and for a tiny and obviously correct change like this, it would not make sense to test. Of course there could be a typo and maybe once every few dozen pull-request I make such an error, but I think it is worth the risk.

Guess I'll just merge this and look into handing over my packages to the Emacs orphanage or something.

Ah so you are aware of my work in that field. :grinning:

Anyway, feel free to transfer your packages there.

It used to be the case that you would have to transfer to my personal account for technical reasons, but I recently saw a ui change that suggested you could transfer directly. In either case, please ping me here after initiating a transfer, because the receiving end is only informed about transfer request by email, the requests expire after a day, and lately I haven't been checking my mail every day.