search

cyrusimap / cassandane

Other
6 stars 11 forks source link

Update tests to use `unixhierarchysep`and `altnamespace`. #25

Closed ajaysusarla closed 7 years ago

ajaysusarla commented 7 years ago

Currently, with the Cassandane tests, we need to explicitly set altnamespace and unixhierarchysep to no (either in the imapd.conf or cassandane.ini(under the [config] section):

altnamespace = no
unixhierarchysep = no

We need to update tests both the unixhierarchysep and altnamespace.

nicolan commented 7 years ago

Well, ideally we want to have the tests to expect the altnamespace/unixhierarchysep to be yes because that's the new defaults for Cyrus master.

Or, if they're explicitly specified, obey their yes/no setting.

ajaysusarla commented 7 years ago

@nicolan ack! @brong has offered to help me with this, so i guess this is as good as fixed! :)

nicolan commented 7 years ago

Also: please update cassandane.ini.example to reflect the values appropriately. (Possibly have two sets: one with a note for 2.4/2.5 saying that product line defaults to altnamespace/unixhierarchysep being off, and one for 3.0 saying cyrus defaults to them being on)

elliefm commented 7 years ago

fyi, we already have #13 open about this ;)

ajaysusarla commented 7 years ago

Thanks for pointing that out @elliefm - will mark this as a duplicate of #13 and close.