Instruct JMAP::TestSuite to include more info in verbose mode

cyrusimap / cassandane

Other

6 stars 11 forks source link

Instruct JMAP::TestSuite to include more info in verbose mode #49

Closed wolfsage closed 6 years ago

wolfsage commented 6 years ago

This includes:

Test output (from ok(), etc)
JMAP::Tester::Logger output about requests/responses to cyrus

elliefm commented 6 years ago

Nice!

We don't usually dump telemetry until get_verbose() >= 3, though. I've twiddled a bit, and the ok() output at level 1 looks good though. :)

Can you also add this patch in, while you're in there? I think it got lost in all the long log dumps in the previous PR. It fixes up the double line endings: https://github.com/cyrusimap/cassandane/pull/44#issuecomment-372877110

elliefm commented 6 years ago

After discussion with @wolfsage, just merging this as is and tweaking the verbosity and newlineyness myself, to avoid a pointlessly-long round trip (I'm away tomorrow)