search

cyrusimap / cassandane

Other
6 stars 11 forks source link

Add :needs_foo_bar attribute for marking tests as dependent on optional features #57

Closed elliefm closed 6 years ago

elliefm commented 6 years ago

Putting this in as a PR mainly to make sure it doesn't break for @jasontibbitts before I merge it down.

jasontibbitts commented 6 years ago

Sorry for the delay; Monday was a US holiday and I took an extra day.

Comparing Cassandane HEAD with and without this patch produces no additional failed tests. Unfortunately Cassandane head brings in a new failure (Cyrus::SearchFuzzy.audit_unindexed calls squatter with the -A flag which doesn't exist on 3.0.7) but with this patch, that failure goes away. I think there are two tests in HEAD which still have return if not $self->{test_fuzzy_search}; (SearchFuzzy test_audit_unindexed and test_weird_crasher) which will result in those tests not running (but appearing to pass) with this PR applied.

brong commented 6 years ago

Oh right... I've marked that audit test for 3.1 only, since it's not back in 3.0.

On Thu, May 31, 2018, at 05:26, Jason Tibbitts wrote:

Sorry for the delay; Monday was a US holiday and I took an extra day.> Comparing Cassandane HEAD with and without this patch produces no additional failed tests. Unfortunately Cassandane head brings in a new failure (Cyrus::SearchFuzzy.audit_unindexed calls squatter with the -A flag which doesn't exist on 3.0.7) but with this patch, that test goes away. I think there are two tests in HEAD which still have return if not $self->{test_fuzzy_search}; (SearchFuzzy test_audit_unindexed and test_weird_crasher) which will result in those tests not running (but appearing to pass) with this PR applied.> — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub[1], or mute the thread[2].

Bron Gondwana, CEO, FastMail Pty Ltd brong@fastmailteam.com

Links:

  1. https://github.com/cyrusimap/cassandane/pull/57#issuecomment-393287078
  2. https://github.com/notifications/unsubscribe-auth/AABE7Y1z2m3cntDNoFVRrl5fL2Kt1exLks5t3vJUgaJpZM4UPr6u
elliefm commented 6 years ago

Unfortunately Cassandane head

Yep, there's been working happening alongside this, so there's a few new tests based on the pre-this-PR architecture, I'll smooth that all out just before I merge :)

Thanks for checking it out!