search

cyrusimap / cassandane

Other
6 stars 11 forks source link

JMAPTestSuite: Don't override search/data partitions #83

Closed wolfsage closed 4 years ago

wolfsage commented 4 years ago

These get filled in anyway for us and they stay around after a test run so that you can look at the raw data.

By using tempdir(), we were mistakenly cleaning up these directories after each test run. Oops.

wolfsage commented 4 years ago

@rsto This should be of interest to you!

elliefm commented 4 years ago

The CI failure is because:

Perl v5.20.0 required--this is only v5.14.4, stopped at ./utils/guid2cid.pl line 4.
BEGIN failed--compilation aborted at ./utils/guid2cid.pl line 4.

Which is nothing to do with this PR, but is instead a file that @brong created recently (a788ffb6). Any chance we can downgrade that use 5.020; line to 5.14, so that travis can successfully check Cassandane PR's? I'm not sure what's different from 5.14=>5.20 to know whether it depends on any new features or not...

brong commented 4 years ago

Yeah, I've just removed the version requirement - it was just for say and it's easy to use print instead and not even need a version.