cyrusimap / cyrus-imapd

Cyrus IMAP is an email, contacts and calendar server
http://cyrusimap.org
Other
543 stars 149 forks source link

sieve_maxscripts should not apply to admins #1047

Open brong opened 16 years ago

brong commented 16 years ago

From: s.e.grier@qmul.ac.uk Bugzilla-Id: 3104 Version: 2.4.x (next) Owner: Ken Murchison

brong commented 16 years ago

From:

The sieve_maxscripts option, IMAPOPT_SIEVE_MAXSCRIPTS in timsieved/actions.c, applies to admins as well as normal users. This means that if I want to limit the number of sieve scripts a normal user may upload, this limit will also apply to the number of global sieve scripts I can upload.

I want to make use of the /vendor/cmu/cyrus-imapd/sieve annotation to provide sieve for shared mailboxes. If I am limited in the number of global sieve scripts I can maintain by sieve_maxscripts I won't be able to make proper use of this functionality.

I suggest a simple patch to timsieved/actions.c to exempt admins from the maxscripts check:

--- timsieved/actions.c.orig Wed Oct 8 16:47:08 2008 +++ timsieved/actions.c Wed Oct 15 16:12:33 2008 @@ -333,7 +333,7 @@ / see if this would put the user over quota / maxscripts = config_getint(IMAPOPT_SIEVE_MAXSCRIPTS);