search

cyrusimap / cyrus-imapd

Cyrus IMAP is an email, contacts and calendar server
http://cyrusimap.org
Other
543 stars 149 forks source link

Mailbox dumping generates IOERROR for missing optional files #1102

Open brong opened 14 years ago

brong commented 14 years ago

From: Julien Coloos Bugzilla-Id: 3214 Version: 2.3.x Owner: Ken Murchison

brong commented 14 years ago

From: Julien Coloos

When dumping a mailbox (imap/mbdump.c) some files associated to the mailbox are mandatory (cyrus header, etc) and some are optional (expunge file, etc). Yet the file dumping function (dump_file) always syslog an IOERROR if requested file is missing, and returns a code error (IMAP_SYS_ERROR) which is discarded by caller if file was actually optional.

When looking at logs those IOERROR are misleading since there is actually no issue. Maybe a new parameter could be added to the dump_file function by the caller, indicating whether the file is mandatory, so that those logs could be avoided in such cases ?

brong commented 12 years ago

From: Julien Coloos

Fixed with commit http://git.cyrusimap.org/cyrus-imapd/commit/imap/mbdump.c?id=33d14f4c7c06c62e1b3781f2e7313c3f50f040a3