search

cyrusimap / cyrus-imapd

Cyrus IMAP is an email, contacts and calendar server
http://cyrusimap.org
Other
528 stars 145 forks source link

Reconstruct should be noisy about uniqueid clashes (whether fixing or not) and sync_client should also make a big noise if there's duplication!!! #2876

Open brong opened 4 years ago

elliefm commented 4 years ago

reconstruct already has this:

https://github.com/cyrusimap/cyrus-imapd/blob/c1e0fb0cb7f2c30543f15ae66f9c6ce643bfed74/imap/reconstruct.c#L471-L489

Should we be chucking one of the "*ERROR:" prefixes onto those messages, so our log monitoring notices them? Which one? What about stderr output?

Replication has this:

https://github.com/cyrusimap/cyrus-imapd/blob/c1e0fb0cb7f2c30543f15ae66f9c6ce643bfed74/imap/sync_support.c#L2758-L2767

and this (which is the opposite of a clash: a uniqueid that changed):

https://github.com/cyrusimap/cyrus-imapd/blob/c1e0fb0cb7f2c30543f15ae66f9c6ce643bfed74/imap/sync_support.c#L2799-L2813