search

cyrusimap / cyrus-imapd

Cyrus IMAP is an email, contacts and calendar server
http://cyrusimap.org
Other
550 stars 151 forks source link

enum_default test fails on ppc64 #3714

Open thesamesam opened 3 years ago

thesamesam commented 3 years ago

Originally reported downstream in Gentoo. Please let me know if I can provide some more useful information!

From 3.0.13 (but it's the same with 3.0.16):

Suite: libconfig
  Test: int ...passed
  Test: string ...passed
  Test: switch ...passed
  Test: stringlist_value ...passed
  Test: stringlist_default ...passed
  Test: stringlist_invalid ...
unit: fatal(invalid value 'junk' for annotation_db in line 2)
passed
  Test: enum_value ...passed
  Test: enum_default ...FAILED
    1. ./cunit/libconfig.testc:210  - CU_ASSERT_EQUAL(delete_mode=0,IMAP_ENUM_DELETE_MODE_DELAYED=1)
  Test: enum_invalid ...
unit: fatal(invalid value 'junk' for delete_mode in line 2)
passed
  Test: bitfield_value ...passed
  Test: bitfield_default ...passed
  Test: bitfield_invalid ...
unit: fatal(invalid value 'junk' for httpmodules in line 2)
passed

3.4.2 fails too with build.log:

Suite: libconfig
  Test: int ...passed
  Test: string ...passed
  Test: switch ...passed
  Test: stringlist_value ...passed
  Test: stringlist_default ...passed
  Test: stringlist_invalid ...
unit: fatal(invalid value 'junk' for annotation_db in line 2)
passed
  Test: enum_value ...passed
  Test: enum_default ...FAILED
    1. ./cunit/libconfig.testc:204  - CU_ASSERT_EQUAL(delete_mode=0,IMAP_ENUM_DELETE_MODE_DELAYED=1)
  Test: enum_invalid ...
unit: fatal(invalid value 'junk' for delete_mode in line 2)
System information Portage 3.0.20 (python 3.9.6-final-0, default/linux/ppc64/17.0, gcc-11.2.0, glibc-2.33-r1, 5.10.68-gentoo-dist-hardened ppc64) ================================================================= System uname: Linux-5.10.68-gentoo-dist-hardened-ppc64-POWER9_-architected-,_altivec_supported-with-glibc2.33 KiB Mem: 32931448 total, 13209884 free KiB Swap: 67108860 total, 67108860 free Timestamp of repository gentoo: Sat, 16 Oct 2021 09:36:34 +0000 sh bash 5.1_p8 ld GNU ld (Gentoo 2.37_p1 p0) 2.37 app-shells/bash: 5.1_p8::gentoo dev-lang/perl: 5.34.0-r2::gentoo dev-lang/python: 3.9.6_p2::gentoo dev-lang/rust-bin: 1.53.0::gentoo dev-util/cmake: 3.20.5::gentoo sys-apps/baselayout: 2.7::gentoo sys-apps/openrc: 0.43.5::gentoo sys-apps/sandbox: 2.24::gentoo sys-devel/autoconf: 2.69-r5::gentoo, 2.71-r1::gentoo sys-devel/automake: 1.16.4::gentoo sys-devel/binutils: 2.37_p1::gentoo sys-devel/gcc: 11.2.0::gentoo sys-devel/gcc-config: 2.4::gentoo sys-devel/libtool: 2.4.6-r6::gentoo sys-devel/make: 4.3::gentoo sys-kernel/linux-headers: 5.10::gentoo (virtual/os-headers) sys-libs/glibc: 2.33-r1::gentoo Repositories: gentoo location: /var/db/repos/gentoo sync-type: rsync sync-uri: rsync://rsync.gentoo.org/gentoo-portage priority: -1000 sync-rsync-verify-metamanifest: yes sync-rsync-extra-opts: sync-rsync-verify-max-age: 24 sync-rsync-verify-jobs: 1 ACCEPT_KEYWORDS="ppc64" ACCEPT_LICENSE="@FREE" CBUILD="powerpc64-unknown-linux-gnu" CFLAGS="-O2 -pipe -frecord-gcc-switches -fdiagnostics-show-option" CHOST="powerpc64-unknown-linux-gnu" CONFIG_PROTECT="/etc /usr/share/gnupg/qualified.txt" CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/dconf /etc/env.d /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo" CXXFLAGS="-O2 -pipe -frecord-gcc-switches -fdiagnostics-show-option" DISTDIR="/var/cache/distfiles" EMERGE_DEFAULT_OPTS="--nospinner --ask-enter-invalid --jobs=4 --load-average 10 --quiet-build --keep-going --with-bdeps=y --complete-graph --deep" ENV_UNSET="CARGO_HOME DBUS_SESSION_BUS_ADDRESS DISPLAY GOBIN GOPATH PERL5LIB PERL5OPT PERLPREFIX PERL_CORE PERL_MB_OPT PERL_MM_OPT XAUTHORITY XDG_CACHE_HOME XDG_CONFIG_HOME XDG_DATA_HOME XDG_RUNTIME_DIR" FCFLAGS="-O2 -pipe -frecord-gcc-switches -fdiagnostics-show-option" FEATURES="assume-digests binpkg-docompress binpkg-dostrip binpkg-logs config-protect-if-modified distlocks ebuild-locks fixlafiles ipc-sandbox multilib-strict network-sandbox news parallel-fetch parallel-install pid-sandbox preserve-libs protect-owned qa-unresolved-soname-deps sandbox sfperms strict unknown-features-warn unmerge-logs unmerge-orphans userfetch userpriv usersandbox usersync xattr" FFLAGS="-O2 -pipe -frecord-gcc-switches -fdiagnostics-show-option" GENTOO_MIRRORS="https://gentoo.osuosl.org/" LANG="C.UTF8" LDFLAGS="-Wl,-O1 -Wl,--as-needed -Wl,--defsym=__gentoo_check_ldflags__=0" MAKEOPTS="-j12 -l10" PKGDIR="/var/tmp/portage/ppc32" PORTAGE_CONFIGROOT="/" PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --omit-dir-times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages --exclude=/.git" PORTAGE_TMPDIR="/var/tmp" USE="acl big-endian bzip2 cli crypt dbus dri elogind fortran gdbm ibm iconv ipv6 libglvnd ncurses nls nptl openmp pam pcre ppc64 readline seccomp split-usr ssl tcpd unicode xattr zlib" ABI_PPC="64" ADA_TARGET="gnat_2019" APACHE2_MODULES="authn_core authz_core socache_shmcb unixd actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" CALLIGRA_FEATURES="karbon sheets words" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock greis isync itrax mtk3301 nmea ntrip navcom oceanserver oldstyle oncore rtcm104v2 rtcm104v3 sirf skytraq superstar2 timing tsip tripmate tnt ublox ubx" INPUT_DEVICES="libinput" KERNEL="linux" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LIBREOFFICE_EXTENSIONS="presenter-console presenter-minimizer" LUA_SINGLE_TARGET="lua5-1" LUA_TARGETS="lua5-1" OFFICE_IMPLEMENTATION="libreoffice" PHP_TARGETS="php7-3 php7-4" POSTGRES_TARGETS="postgres12 postgres13" PYTHON_SINGLE_TARGET="python3_9" PYTHON_TARGETS="python3_9" RUBY_TARGETS="ruby27" USERLAND="GNU" VIDEO_CARDS="fbdev mga nv r128 radeon dummy v4l" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq proto steal rawnat logmark ipmark dhcpmac delude chaos account" Unset: CC, CPPFLAGS, CTARGET, CXX, INSTALL_MASK, LC_ALL, LINGUAS, PORTAGE_BINHOST, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS, RUSTFLAGS
elliefm commented 3 years ago

That's weird... and I have no immediate insight as to why that might be happening in an architecture-specific manner.

I'm not real familiar with Gentoo -- does Gentoo packaging include its own patches? If so are they viewable anywhere? Does anything change if you build directly from one of our release tarballs? (Please use a "cyrus-imapd-x.y.z.tar.gz" file, not the "Source code" files that github provides automatically.)

Do you have hardware you can re-run this on to collect some deeper diagnostics, or are you just passing on the report from downstream?

thesamesam commented 3 years ago

That's weird... and I have no immediate insight as to why that might be happening in an architecture-specific manner.

Especially since broadly the same configure options should be used on other architectures (see below). The exceptions would be for where certain dependencies for optional features may not be available on a certain architecture where we might disable it. I'll look for the difference between a machine which passes (amd64) and this one now.

I'm not real familiar with Gentoo -- does Gentoo packaging include its own patches? If so are they viewable anywhere? Does anything change if you build directly from one of our release tarballs? (Please use a "cyrus-imapd-x.y.z.tar.gz" file, not the "Source code" files that github provides automatically.)

Okay, so I tried building outside and it passed! But I wasn't using the same ./configure options as the Gentoo packaging (ebuilds). You can see our current packaging here (no patches applied atm).

When I do use the same, it fails outside (built manually):

./configure --prefix=/usr --build=powerpc64-unknown-linux-gnu --host=powerpc64-unknown-linux-gnu --mandir=/usr/share/man --infodir=/usr/share/info --datadir=/usr/share --sysconfdir=/etc --localstatedir=/var/lib --disable-dependency-tracking --disable-silent-rules --docdir=/usr/share/doc/cyrus-imapd-3.4.2-r1  --htmldir=/usr/share/doc/cyrus-imapd-3.4.2-r1/html --with-sysroot=/ --libdir=/usr/lib64 --enable-murder --enable-idled --enable-autocreate --enable-pcre --with-com_err --with-cyrus-user=cyrus --with-sasl --with-sphinx-build=no --without-krb --without-krbdes --enable-squat --with-zlib --disable-afs --disable-krb5afspts --disable-backup --disable-calalarmd --without-libcap --without-clamav --disable-nntp --disable-http --without-nghttp2 --disable-replication  --disable-gssapi --without-ldap --without-mysql --without-pgsql --without-perl --without-sqlite --with-openssl --enable-server --disable-sieve --disable-static --with-libwrap --disable-xapian --enable-unit-tests

I've not yet narrowed down to what though. Will try...

This is good though in that it would rule out weird sandbox issues.

Do you have hardware you can re-run this on to collect some deeper diagnostics, or are you just passing on the report from downstream?

I do! I've managed to reproduce this myself and am happy to run and try debug as much as possible with guidance, but if it comes to it, I should be able to arrange for access if it's needed.

EDIT:

Good on amd64:

./configure --prefix=/usr --build=x86_64-pc-linux-gnu --host=x86_64-pc-linux-gnu --mandir=/usr/share/man --infodir=/usr/share/info --datadir=/usr/share --sysconfdir=/etc --localstatedir=/var/lib --disable-dependency-tracking --disable-silent-rules --docdir=/usr/share/doc/cyrus-imapd-3.4.2-r1 --htmldir=/usr/share/doc/cyrus-imapd-3.4.2-r1/html --with-sysroot=/ --libdir=/usr/lib64 --enable-murder --enable-idled --enable-autocreate --enable-pcre --with-com_err --with-cyrus-user=cyrus --with-sasl --with-sphinx-build=no --without-krb --without-krbdes --enable-squat --with-zlib --disable-afs --disable-krb5afspts --disable-backup --disable-calalarmd --with-libcap --without-clamav --disable-nntp --disable-http --without-nghttp2 --disable-replication --disable-gssapi --without-ldap --without-mysql --without-pgsql --without-perl --without-sqlite --with-openssl --enable-server --disable-sieve --disable-static --without-libwrap --disable-xapian --enable-unit-tests

Bad on ppc64:

./configure --prefix=/usr --build=powerpc64-unknown-linux-gnu --host=powerpc64-unknown-linux-gnu --mandir=/usr/share/man --infodir=/usr/share/info --datadir=/usr/share --sysconfdir=/etc --localstatedir=/var/lib --disable-dependency-tracking --disable-silent-rules --docdir=/usr/share/doc/cyrus-imapd-3.4.2-r1  --htmldir=/usr/share/doc/cyrus-imapd-3.4.2-r1/html --with-sysroot=/ --libdir=/usr/lib64 --enable-murder --enable-idled --enable-autocreate --enable-pcre --with-com_err --with-cyrus-user=cyrus --with-sasl --with-sphinx-build=no --without-krb --without-krbdes --enable-squat --with-zlib --disable-afs --disable-krb5afspts --disable-backup --disable-calalarmd --without-libcap --without-clamav --disable-nntp --disable-http --without-nghttp2 --disable-replication  --disable-gssapi --without-ldap --without-mysql --without-pgsql --without-perl --without-sqlite --with-openssl --enable-server --disable-sieve --disable-static --with-libwrap --disable-xapian --enable-unit-tests

diff (excluding the boilerplate bits):

--- /tmp/good
+++ /tmp/bad
@@ -19,7 +19,7 @@
 --enable-unit-tests
 --with-com_err
 --with-cyrus-user=cyrus
---with-libcap
+--with-libwrap
 --with-openssl
 --with-sasl
 --with-sphinx-build=no
@@ -28,7 +28,7 @@
 --without-krb
 --without-krbdes
 --without-ldap
---without-libwrap
+--without-libcap
 --without-mysql
 --without-nghttp2
 --without-perl

But using the 'good'-from-amd64 command line on ppc64 fails. If I copy/paste the amd64 one (including the incorrect --host and such), it surprisingly does pass, but I have no idea why. Probably just a distraction.

elliefm commented 3 years ago

--without-perl is an interesting choice. What happens if you omit this (and let it find and use some system perl)? (Heads up: it'll also install some Cyrus:: perl modules, which is probably what the use of --without-perl was trying to avoid.)

We know --with-perl=/some/other/perl is weird/broken in various ways (#2887), so I wonder if --without-perl (aka --with-perl=no) is similarly affected.

Though it would be strange if this affects only one unit test... but this was already pretty strange, so I'm not ruling out things that seem unrelated

Are you fluent in gdb? There might be a few things interesting to look at while stepping through the failing test -- let me know your skill level, and I'll think about what I want to ask you to try!

For what it's worth, GitHub doesn't send a new email notification for comment edits, so if it makes no difference to you, I'd prefer if you added new information by just adding a new comment. There's no stigma against double posting here. :)

elliefm commented 3 years ago

For whatever it's worth, looks like Debian's ppc64 build works okay: https://buildd.debian.org/status/fetch.php?pkg=cyrus-imapd&arch=ppc64&ver=3.4.2-2&stamp=1631513029&raw=0

I thought it might be some endianness thing we'd missed, but if that were the case I'd expect it to fail for Debian too.

I've just tried building locally with --without-perl and it worked fine for me, but that's unsurprising since I'm also on amd64, where it also worked for you.

thesamesam commented 3 years ago

--without-perl is an interesting choice. What happens if you omit this (and let it find and use some system perl)? (Heads up: it'll also install some Cyrus:: perl modules, which is probably what the use of --without-perl was trying to avoid.)

Let me try that. It looks like we provide it optionally ("USE flags") but that flag is off by default for our cyrus-imapd package.

We know --with-perl=/some/other/perl is weird/broken in various ways (#2887), so I wonder if --without-perl (aka --with-perl=no) is similarly affected.

Though it would be strange if this affects only one unit test... but this was already pretty strange, so I'm not ruling out things that seem unrelated

Are you fluent in gdb? There might be a few things interesting to look at while stepping through the failing test -- let me know your skill level, and I'll think about what I want to ask you to try!

I'm not a ninja but I should be able to poke well enough given a few hints. I'd say suggest what you want, and if it's too hard, I'll let you know?

For what it's worth, GitHub doesn't send a new email notification for comment edits, so if it makes no difference to you, I'd prefer if you added new information by just adding a new comment. There's no stigma against double posting here. :)

Got it, thank you! I'll do that :)

For whatever it's worth, looks like Debian's ppc64 build works okay: buildd.debian.org/status/fetch.php?pkg=cyrus-imapd&arch=ppc64&ver=3.4.2-2&stamp=1631513029&raw=0

I thought it might be some endianness thing we'd missed, but if that were the case I'd expect it to fail for Debian too.

Interestingly, it seems to pass on my little-endian ppc64 machine (it should be as identical as possible to the big-endian environment).

thesamesam commented 3 years ago

OK, fails with Perl too.

dilyanpalauzov commented 3 years ago

--enable-pcre used in the past to lead to failing tests. In the 'good' command line, pcre is not used. You can grep the archives on ‘pcre’ to find more.

elliefm commented 3 years ago

It's present in both...

But, PCRE is known to be a nuisance. Debian patches it, but I don't know if Gentoo does. And maybe there's an endianness problem or platform-specific quirk.

Very interested to hear what results you get from removing --enable-pcre, on both good- and bad- systems. Or you might need to --disable-pcre, I don't remember whether it will be automatically used if it's found installed...