search

cyrusimap / cyrus-imapd

Cyrus IMAP is an email, contacts and calendar server
http://cyrusimap.org
Other
544 stars 149 forks source link

timsieved error message unclear #645

Closed brong closed 14 years ago

brong commented 20 years ago

From: Rob Siemborski Bugzilla-Id: 2403 Version: 2.2.x Owner: Rob Siemborski

brong commented 20 years ago

From: Rob Siemborski

I just spent several hours tracking down an error with someone trying to upload a sieve script using the avelsieve squirrelmail plugin.

The error message, as reported by timsieved file parser.c line 308 was "Did not specify script data", when in fact the problem is (and could only be at that point in the file) "Did not specify script length, or script is too big".

Of course, the reason ended up being that the script exceeded the default 32k limit which I upped and resolved the issue. But really, that error text should be made more clear IMNSHO :)

brong commented 20 years ago

From: Ken Murchison

I already changed the message to read "Did not specify legal script data length". If we want to include the max size in the message, we'll need to construct the message in a static buffer.

brong commented 20 years ago

From: Rob Siemborski

no, I think this is good enough. closing.