search

cyrusstoller / vue-plaid-link

A Vue.js component for Plaid Link
MIT License
14 stars 6 forks source link

Destroy existing handler on reopen #7

Closed skosito closed 3 years ago

skosito commented 3 years ago

If you close and reopen plaid link, it will keep on stacking iframes in dom. This fix destroys existing link handler before new one is created. According to plaid docs, calling destroy will make sure iframe is also removed. Not sure if destroy should be called onExit, but checking other implementation (like react plaid), they are doing the check before create as well.

@cyrusstoller could you please check this and give me your thoughts? Thanks!

cyrusstoller commented 3 years ago

Great suggestion. Thanks for the PR. Merging now.

cyrusstoller commented 3 years ago

Merged b6096efd5eaa0f630cb3c5c89f3f4fea2d9c6214