cytechmobile / radicle-jetbrains-plugin

Radicle plugin for Jetbrains IDEs
https://plugins.jetbrains.com/plugin/19664-radicle
Apache License 2.0
15 stars 0 forks source link

fix(Null exception): View file diff in a patch #471

Closed Stelios123 closed 8 months ago

Stelios123 commented 9 months ago

When the user tried to view a file diff the was an error at the calculation of the modified lines and we were getting null exception in some cases. Fix this bug by adjusting the modifiedLines method and also enable the user to add review comments in both files when viewing the diff.

github-actions[bot] commented 9 months ago

Qodana Community for JVM

6 new problems were found

Inspection name Severity Problems
Nullability and data flow problems 🔶 Warning 4
Deprecated API usage 🔶 Warning 1
Unstable API Usage 🔶 Warning 1

💡 Qodana analysis was run in the pull request mode: only the changed files were checked

View the detailed Qodana report To be able to view the detailed Qodana report, you can either: 1. Register at [Qodana Cloud](https://qodana.cloud/) and [configure the action](https://github.com/jetbrains/qodana-action#qodana-cloud) 2. Use [GitHub Code Scanning with Qodana](https://github.com/jetbrains/qodana-action#github-code-scanning) 3. Host [Qodana report at GitHub Pages](https://github.com/JetBrains/qodana-action/blob/3a8e25f5caad8d8b01c1435f1ef7b19fe8b039a0/README.md#github-pages) 4. Inspect and use `qodana.sarif.json` (see [the Qodana SARIF format](https://www.jetbrains.com/help/qodana/qodana-sarif-output.html#Report+structure) for details) To get `*.log` files or any other Qodana artifacts, run the action with `upload-result` option set to `true`, so that the action will upload the files as the job artifacts: ```yaml - name: 'Qodana Scan' uses: JetBrains/qodana-action@v2023.3.1 with: upload-result: true ```
Contact Qodana team Contact us at [qodana-support@jetbrains.com](mailto:qodana-support@jetbrains.com) - Or via our issue tracker: https://jb.gg/qodana-issue - Or share your feedback: https://jb.gg/qodana-discussions