search

cytechmobile / radicle-jetbrains-plugin

Radicle plugin for Jetbrains IDEs
https://plugins.jetbrains.com/plugin/19664-radicle
Apache License 2.0
15 stars 0 forks source link

Merge patch visibility #492

Open JChrist opened 6 months ago

JChrist commented 6 months ago

When selecting to merge a patch, there is no check currently if the current user is a delegate of the project or not. If the current user is not a delegate, merging the patch will most probably NOT be what the user really wanted to do. In that case, I think it's better to not allow the user to merge the patch, i.e. completely hide the button.

gsaslis commented 5 months ago

Need to compare this with rad behaviour.

Patch will still not transition to merged.

Maybe we can show a dialog that explains that non-delegates are just merging the patch to their own history.

gsaslis commented 5 months ago

if we disable the button, we need to add a tooltip / message above the button, that it is disabled because user is not a delegate.