Show comments from all revisions

cytechmobile / radicle-jetbrains-plugin

Radicle plugin for Jetbrains IDEs

https://plugins.jetbrains.com/plugin/19664-radicle

Apache License 2.0

15 stars 0 forks source link

Show comments from all revisions #509

Closed gsaslis closed 2 months ago

gsaslis commented 5 months ago

In the timeline, I can see comments from all revisions.

But when reviewing the diff, I can't see comments from non-latest revision. This has the problem that when adding a new commit e.g. to fix one of the inline comments, I can no longer see the comment (even if the commit changed an unrelated line).

Cases:

a comment is left on a line that is not changed in a subsequent revision (the diff remains the same)
a comment is left on a line that is later changed in a following commit
a comment is left on a line in a file that is later deleted
a comment is left on a line in a file that is renamed
a comment is edited

gsaslis commented 3 months ago

let's add commented on $path:$line_number (outdated) in the overall timeline view
we won't show comments that are in cases 2,3,4 for now (because they can be seen in the timeline view - and the diff view will just show latest changes)

Stelios123 commented 3 months ago

I perform a test to measure the time required to render comments. There were a total of 25 comments, of which 17 were outdated and 8 were current on the latest revision. The rendering process took 3.5 seconds

gsaslis commented 3 months ago

@Stelios123 having this working - even if it takes a few seconds - is certainly an improvement over not having it at all - which is blocking proper code reviews (which is a major issue).

Let's move forward and we can come back in the future to improve performance here.

Stelios123 commented 3 months ago

Ok we will continue with the merge