This PR removes a duplicative and all-at-once concatenate during CytoTable join operations. It was discovered while trying to replicate / confirm findings for #38 with SQ00014613.sqlite (which appears to no longer face direct challenges with data value translation but faces large memory resource consumption issues as a result of the removed block in this PR). After this is applied we should see performance benefits (as join concatenation will only take place once) and better opportunity to avoid memory resource constraint issues.
References #38
Likely effects discussion on recommendations in #163
What is the nature of your change?
[x] Bug fix (fixes an issue).
[ ] Enhancement (adds functionality).
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected).
[ ] This change requires a documentation update.
Checklist
Please ensure that all boxes are checked before indicating that a pull request is ready for review.
Description
This PR removes a duplicative and all-at-once concatenate during CytoTable join operations. It was discovered while trying to replicate / confirm findings for #38 with
SQ00014613.sqlite
(which appears to no longer face direct challenges with data value translation but faces large memory resource consumption issues as a result of the removed block in this PR). After this is applied we should see performance benefits (as join concatenation will only take place once) and better opportunity to avoid memory resource constraint issues.References #38 Likely effects discussion on recommendations in #163
What is the nature of your change?
Checklist
Please ensure that all boxes are checked before indicating that a pull request is ready for review.