cytomining / CytoTable

Transform CellProfiler and DeepProfiler data for processing image-based profiling readouts with Pycytominer and other Cytomining tools.
https://cytomining.github.io/CytoTable/
BSD 3-Clause "New" or "Revised" License
7 stars 5 forks source link

Use compartment tables as basis of preset joins #183

Closed d33bs closed 5 months ago

d33bs commented 6 months ago

Description

This PR changes the way SQL-based joins in presets produce data to avoid scenarios where there is image table data but no associated compartment table data. Many thanks to @jenna-tomkinson who helped provide details and troubleshooting via #86. To help make sure we don't run into this challenge again, I've added a test using data related to #86.

This change is based off of and should be merged after #182 .

Closes #86

What is the nature of your change?

Checklist

Please ensure that all boxes are checked before indicating that a pull request is ready for review.

d33bs commented 5 months ago

Thank you @gwaybio ! Merging this in.