cytomining / cytominer-eval

[Deprecated] Common Evaluation Metrics for DataFrames
BSD 3-Clause "New" or "Revised" License
7 stars 11 forks source link

Intake lists #52

Closed michaelbornholdt closed 3 years ago

michaelbornholdt commented 3 years ago

Enrichment and Precision recall shall intake a list of variables. This way the similarity matrix is only computed once!

codecov-commenter commented 3 years ago

Codecov Report

Merging #52 (5fb4d24) into master (220b296) will decrease coverage by 0.09%. The diff coverage is 97.29%.

:exclamation: Current head 5fb4d24 differs from pull request most recent head 04be210. Consider uploading reports for the commit 04be210 to get more accurate results Impacted file tree graph

@@            Coverage Diff             @@
##           master      #52      +/-   ##
==========================================
- Coverage   98.36%   98.26%   -0.10%     
==========================================
  Files          24       24              
  Lines         855      865      +10     
==========================================
+ Hits          841      850       +9     
- Misses         14       15       +1     
Flag Coverage Δ
unittests 98.26% <97.29%> (-0.10%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cytominer_eval/evaluate.py 100.00% <ø> (ø)
cytominer_eval/tests/test_evaluate.py 100.00% <ø> (ø)
cytominer_eval/operations/enrichment.py 95.45% <93.33%> (-4.55%) :arrow_down:
cytominer_eval/operations/precision_recall.py 100.00% <100.00%> (ø)
...iner_eval/tests/test_operations/test_enrichment.py 100.00% <100.00%> (ø)
...val/tests/test_operations/test_precision_recall.py 100.00% <100.00%> (ø)
cytominer_eval/transform/util.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 220b296...04be210. Read the comment docs.

michaelbornholdt commented 3 years ago

@gwaygenomics This last Commit should fix every thing. So this is ready for review :)

michaelbornholdt commented 3 years ago

Fixes #51

michaelbornholdt commented 3 years ago

Ah, I still need to run the Demo notebook

michaelbornholdt commented 3 years ago

@gwaygenomics I reran the demo, All up to do date now

michaelbornholdt commented 3 years ago

@gwaygenomics should be done with all your comments now

michaelbornholdt commented 3 years ago

@gwaygenomics ready for you to look at again :)

michaelbornholdt commented 3 years ago

@gwaygenomics back to you again :)

michaelbornholdt commented 3 years ago

What is this change request, how do I get rid of it?

gwaybio commented 3 years ago

No worries, I get rid of it when I finally approve. Looking now

gwaybio commented 3 years ago

Wonderfully done - merging now