codecov-commenter
commented
3 years ago Codecov Report
Merging #58 (9cc2741) into master (9569721) will increase coverage by
0.07%. The diff coverage is100.00%.
@@ Coverage Diff @@
## master #58 +/- ##
==========================================
+ Coverage 98.45% 98.53% +0.07%
==========================================
Files 30 30
Lines 905 954 +49
==========================================
+ Hits 891 940 +49
Misses 14 14 | Flag | Coverage Δ | |
|---|---|---|
| unittests | 98.53% <100.00%> (+0.07%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
| Impacted Files | Coverage Δ | |
|---|---|---|
| ...iner_eval/tests/test_utils/test_transform_utils.py | 100.00% <ø> (ø) |
|
| cytominer_eval/operations/grit.py | 100.00% <100.00%> (ø) |
|
| cytominer_eval/tests/test_operations/test_grit.py | 100.00% <100.00%> (ø) |
|
| ...ominer_eval/tests/test_transform/test_transform.py | 100.00% <100.00%> (ø) |
|
| ...r_eval/tests/test_utils/test_availability_utils.py | 100.00% <100.00%> (ø) |
|
| cytominer_eval/tests/test_utils/test_grit_utils.py | 100.00% <100.00%> (ø) |
|
| ...iner_eval/tests/test_utils/test_operation_utils.py | 100.00% <100.00%> (ø) |
|
| cytominer_eval/transform/transform.py | 97.05% <100.00%> (-0.09%) |
:arrow_down: |
| cytominer_eval/utils/availability_utils.py | 100.00% <100.00%> (ø) |
|
| cytominer_eval/utils/grit_utils.py | 100.00% <100.00%> (ø) |
|
| ... and 2 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update 9569721...9cc2741. Read the comment docs.
gwaybio
michaelbornholdt
This PR extends the refactor from #55 and adds a function to the grit calculation to summarize two distributions.
More specifically:
utils/availability_utils.pyfile. This refactor makes adding new methods, checking for their compatibility, and testing much easier.utils.operation_utils.compare_distributions()which currently only accepts one method ("zscore", which is grit default)In trying to keep pull request to bite-sized chunks, I will only add additional methods to summarizing the reference and replicate pairwise distributions in a future pull request.