cytomining / cytominer-transport

[Deprecated]
Other
1 stars 2 forks source link

Option to output parent/child aligned single cell profiles instead of image/object number #8

Open gwaybio opened 3 years ago

gwaybio commented 3 years ago

Currently cytominer_transport/_generator.py combines objects based on "ImageNumber" and "ObjectNumber".

Instead, we should consider combining objects by their appropriate "Parent{compartment}" and "Child{compartment}".

Pros

Cons

https://github.com/cytomining/cytominer-transport/blob/056ced308c1d03790acdfb5a5e90f29a9fab0e4d/src/cytominer_transport/_generator.py#L64-L66

Notes

gwaybio commented 3 years ago

Below is how pycytominer currently addresses this:

https://github.com/cytomining/pycytominer/blob/838ac2eee8bee09b50a1ec8077201c01f7882c69/pycytominer/cyto_utils/single_cell_ingest_utils.py#L5-L23

bethac07 commented 3 years ago

A complication here is that, in the case of multiple objects, there can be many relationship types-

I think the logic to detect and/or support all of them might be rough; we should consider how to handle each of them, and whether or not the user needs to pass a flag or a configuration or something to make it easier to decide.